Pair with a developer and review some of your existing automation.
This time I checked ahead of time and actually did this challenge in time (before the weekend).
Quick summary of the feedback I received (I still have to implement some of these recommendations).
- Don’t repeat yourself (DRY).
- Some tests can be moved to another level.
- Not all tests add value.
- Still some flaky tests.
- Remove the Thread.sleep (This was on my to-do list already. I just like to use thread.sleep when I want to quickly add tests/checks. Refactoring this comes later).
- Some tests can be changed to be data-driven.
That’s it. Plenty things to improve on. I actually got a fair amount of compliments as well, but ofcourse I did not write those down (silly me).